Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent crashing when a component is null #26

Merged
merged 3 commits into from
Nov 15, 2017
Merged

Prevent crashing when a component is null #26

merged 3 commits into from
Nov 15, 2017

Conversation

joshwnj
Copy link
Contributor

@joshwnj joshwnj commented Nov 13, 2017

I'm seeing this error in the console when a component returns null from its render function: TypeError: Object.defineProperty called on non-object

I've added some failing specs and modified core/snapshot.js to make them pass.

PS. thanks for this library!

@MicheleBertoli
Copy link
Collaborator

This is awesome, thank you very much @joshwnj.
Good catch, and thanks for adding some tests as well.

@MicheleBertoli MicheleBertoli merged commit 9ffdeb8 into styleguidist:master Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshwnj @MicheleBertoli